Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributing guide: ran into an issue while installing tests #2012

Open
learningboiz opened this issue May 20, 2023 · 2 comments
Open

contributing guide: ran into an issue while installing tests #2012

learningboiz opened this issue May 20, 2023 · 2 comments

Comments

@learningboiz
Copy link
Contributor

Followed the contribution guide and faced an error when installing the tests.

Specs

  • Python 3.9.12
  • Django 4.2.1
  • zsh 5.8.1

Steps to reproduce

  1. Fork django/channels repo
  2. Clone repo into local machine with git clone git@github.com:your-username/channels.git
  3. Activate virtual environment
  4. Move into channels directory with cd channels
  5. Install tests with python -m pip install -e .[tests]

Error
zsh: no matches found: .[tests]

After some research, I identified that the [] might have been interpreted by zsh as a wildcard to match files similar to tests. After wrapping it around quotations (i.e '[tests]'), I managed to succeed with installations.

Not sure if it's just an isolated issue — just thought to raise it up in case it's worth mentioning.

@carltongibson
Copy link
Member

Yes it's a zsh vs bash thing. You could suggest a change there if you'd like! Thanks.

@learningboiz
Copy link
Contributor Author

Sure thing, I've raised a PR regarding this. Sorry it took awhile — was swamped recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants