Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Slovak local name. #18017

Merged
merged 1 commit into from
May 8, 2024
Merged

Corrected Slovak local name. #18017

merged 1 commit into from
May 8, 2024

Conversation

gardenerik
Copy link
Contributor

@gardenerik gardenerik commented Mar 25, 2024

Trac ticket number

N/A

Branch description

When talking about the Slovak language in the form "slovensky", it is correct to use lower case letters.

The same can be found (but already correct) in django/conf/locale/sk/LC_MESSAGES/django.po, line 260.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • For UI changes, I have attached screenshots in both light and dark modes.

In this case, lower case is grammatically correct. See also correct
translation in django/conf/locale/sk/LC_MESSAGES/django.po, line 260.
@gardenerik gardenerik changed the title Fixes casing of Slovak local name in LANG_INFO. Fixed casing of Slovak local name in LANG_INFO. Mar 25, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for your contribution 💪

As it's your first contribution be sure to check out the patch review checklist.

If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!

If you have any design or process questions then you can ask in the Django forum.

Welcome aboard ⛵️!

@felixxm
Copy link
Member

felixxm commented Mar 25, 2024

@gardenerik Thanks 👍

@jangondol Can you confirm this change?

@felixxm
Copy link
Member

felixxm commented Mar 25, 2024

Looks like a regression in b0ad508 (ticket-25717).

@felixxm felixxm changed the title Fixed casing of Slovak local name in LANG_INFO. Corrected Slovak local name. Mar 25, 2024
@nessita
Copy link
Contributor

nessita commented Apr 4, 2024

/remind me to check on confirmation in one month

Copy link

github-actions bot commented Apr 4, 2024

@nessita set a reminder for 5/4/2024

Copy link

github-actions bot commented May 4, 2024

👋 @nessita, check on confirmation

@github-actions github-actions bot removed the reminder label May 4, 2024
Copy link
Member

@bmispelon bmispelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had the chance to speak to a native Slovak speaker who approved these changes 👍🏻

@nessita
Copy link
Contributor

nessita commented May 8, 2024

I've had the chance to speak to a native Slovak speaker who approved these changes 👍🏻

Thank you so much!

@nessita nessita merged commit d59066b into django:main May 8, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants