Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot overwrite windows newrelic-infra agent source #373

Open
jhuaMFC opened this issue Feb 7, 2019 · 1 comment
Open

Cannot overwrite windows newrelic-infra agent source #373

jhuaMFC opened this issue Feb 7, 2019 · 1 comment

Comments

@jhuaMFC
Copy link

jhuaMFC commented Feb 7, 2019

I am writing a wrapper cookbook around newrelic cookbook.

def install_newrelic_infrastructure_service_windows
  windows_package 'newrelic-infra' do
    source "https://download.newrelic.com/infrastructure_agent/windows/newrelic-infra.#{new_resource.windows_version}.msi"
    installer_type :msi
    version new_resource.windows_version
    action new_resource.action
    checksum new_resource.windows_checksum
  end

  # lay down newrelic-infra agent config
  template 'C:\Program Files\New Relic\newrelic-infra\newrelic-infra.yml' do
    cookbook new_resource.template_cookbook
    source new_resource.template_source
    variables(
      :resource => new_resource
    )
    sensitive true
    notifies :restart, 'service[newrelic-infra]', :delayed
  end

  # setup newrelic-infra service
  service 'newrelic-infra' do
    action new_resource.service_actions
  end
end

It would be helpful if the source attribute can be overwritten through new_resource instead of just the version number.

@djoos
Copy link
Member

djoos commented Jun 11, 2020

I'm happy to get this change in, if done inline with eg. https://github.com/djoos-cookbooks/newrelic/blob/master/resources/agent_java.rb#L13 + https://github.com/djoos-cookbooks/newrelic/blob/master/providers/agent_java.rb#L57.

If possible, ping me a PR and I'll review it!

@djoos djoos closed this as completed Jun 11, 2020
@djoos djoos reopened this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants