iOS 16: App freezes and hangs when trying to build WrappingHStack content

[SetSailSwift]

Describe the bug
When scrolling through items that contain a WrappingHStack instance in the component, our app freezes but never crashes. This is due to the main thread getting clogged up when trying to create a WrappingHStack for our component.

To Reproduce
Use a WrappingHStack instance in component, adding that component into a scroll view.
Try to scroll through items on iOS 16 device.

Expected behavior
Should be able scroll through feed without freezing.

Screenshots
Thread Capture

Line in InternalWrappingHStack that appears to be clogging thread:

In the below give, the tags in each card is contained in a WrappingHStack instance:

Context:

• WrappingHStack version: 2.2.1
• Model: All
• OS: iOS 16.0.2

Additional context
Appears to be related to issues #27 & #28.

[x-sheep]

This happens to me as well. I had the WrappingHStack in a ScrollView, and when it scrolled into view the app froze entirely. Since iPadOS does not yet have an upgrade to 16 available, it works fine on iPads but not iPhones.

[SetSailSwift]

@dkk are you still supporting this package? I saw in #27 it affects v2.2.2 as well but noticed you are removing yourself from the assignments. I just wanted to clarify if the iOS 16 issue would be looked at in the future or if I'll need to pivot to another solution for now. Thanks!

[x-sheep]

iOS 16 has introduced the Layout protocol. If fixing the current implementation for iOS 16 isn't working out, it may be worth considering reimplementing the WrappingHStack using the new system, then conditionally switching back to the old system using if #available blocks based on the user's iOS version.

https://developer.apple.com/documentation/swiftui/custom-layout

[dkk]

@SetSailSwift I'm still supporting, but currently I don't have a lot of spare time. I am removing my assignments to let anyone willing to help know that there are issues and that nobody is working on them at the moment.

[SetSailSwift]

@dkk Understood. Thanks for clarifying!

[MikeMorawski]

It looks like its an issue with let itemWidth = hostingController.view.intrinsicContentSize.width as this line specifically will cause a never ending reinitialization.

The loop only occurs when a parent GeometryReader geo.frame(in: .global) reference, which continues the feedback loop, as is the case with it required in WrappingHStack.

[MikeMorawski]

One last note, it looks like swapping from intrinsicContentSize to sizeThatFits does not cause the feedback loop, but not sure exactly how to fit that into the current solution just yet.

[dkk]

Closing for now, if you still have this issues 2.2.3, please reopen.