Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove custom sort code in favor of sort:updated #225

Open
robdimsdale opened this issue Jan 18, 2023 · 1 comment
Open

Refactor: remove custom sort code in favor of sort:updated #225

robdimsdale opened this issue Jan 18, 2023 · 1 comment

Comments

@robdimsdale
Copy link
Contributor

robdimsdale commented Jan 18, 2023 •
edited

As requested in this comment - let's refactor the codebase to remove custom sorting and instead add a default sort:updated when fetching issues and PRs. See GitHub documentation for more info on this filter.
@robdimsdale robdimsdale mentioned this issue Jan 18, 2023
Merged
@robdimsdale
Copy link
Contributor Author

This was partially fixed inline as part of #223 . But there are other instances of sort.Slice (e.g. here) that could be refactored also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robdimsdale