Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] repoPaths are case sensitive #308

Open
Sanix-Darker opened this issue Oct 11, 2023 · 0 comments
Open

[BUG] repoPaths are case sensitive #308

Sanix-Darker opened this issue Oct 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Sanix-Darker
Copy link
Contributor

Sanix-Darker commented Oct 11, 2023

Describe the bug
The repoName should lower down along side withthe given path
because TheAuthor/repo1 seems not equal to Theauthor/repo1,
which is not true because those two redirect to the same project
on github.

To Reproduce
Steps to reproduce the behavior:

  1. Just set a repo name in the repoPath section with MAJ or MIN, dash will crash when you try to run a custom command saying the path for the given repo is not available.

Expected behavior
Should not crash an resolve the repo(path and name) even with upper or lower cases + more details on the error maybe ?

	if !ok {
		return func() tea.Msg {
			return constants.ErrMsg{Err: fmt.Errorf(
				"Failed to find local path for repo %s from path: '%s'",
				repoName, repoPath,
			)}
		}
	}

if !ok {

Screenshots
Screenshot from 2023-10-11 09-03-18

Desktop (please complete the following information):

  • Not Os related
@Sanix-Darker Sanix-Darker added the bug Something isn't working label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant