Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce size of npm package #50

Open
3 of 4 tasks
eWert-Online opened this issue Jul 1, 2021 · 5 comments
Open
3 of 4 tasks

Reduce size of npm package #50

eWert-Online opened this issue Jul 1, 2021 · 5 comments

Comments

@eWert-Online
Copy link
Collaborator

eWert-Online commented Jul 1, 2021

I recently investigated why the size of the package is that big and found out, that we include a lot of unnecessary stuff.
It also seems like esy includes the RunTests.exe in the release build.

Things that can be removed from the package:

  • odiff-Linux-xxx.tar.gz
  • odiff-MacOS-xxx.tar.gz
  • odiff-Windows_x64-xxx.tar.gz
  • RunTests.exe
@dmtrKovalenko
Copy link
Owner

I am not publishing them on npm https://www.jsdelivr.com/package/npm/odiff-bin I left them to publish as assets to GitHub release (I know one team that are using raw binaries to run odiff)

@eWert-Online
Copy link
Collaborator Author

Ah I see! But the RunTests.exe is something which could be removed, right?

@dmtrKovalenko
Copy link
Owner

Is it there?

@eWert-Online
Copy link
Collaborator Author

Yes, in the bin folder after you install it.
So it seems to be packaged by esy

Bildschirmfoto 2021-07-01 um 13 19 58

@dmtrKovalenko
Copy link
Owner

Hmmm it is weird, I thought "includePackages": [ "odiff" ] should do the trick but yeah we should not add this to the binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants