Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spigot & Paper class name mismatches for EnumChatVisibility #2926

Closed
1 task done
0utplay opened this issue May 13, 2024 · 5 comments · Fixed by #2928
Closed
1 task done

Spigot & Paper class name mismatches for EnumChatVisibility #2926

0utplay opened this issue May 13, 2024 · 5 comments · Fixed by #2928

Comments

@0utplay
Copy link

0utplay commented May 13, 2024

  • This issue is not solved in a development build

Describe the bug
Some of the enum wrapper classes on spigot servers do not match the names on paper servers.
One example I stumbled upon is EnumChatVisibility (spigot) & ChatVisibility (paper)

To Reproduce
Start a paper (1.20.6) server with the latest protocollib build.
Use any EnumWrapper (causes the init)

Expected behavior
Support for both spigot & paper

Screenshots
Spigot:
image
Paper:
image

The issue I noticed:
image

Version Info
https://pastebin.com/z13YdYad

Additional context
I'm willing to do some work on this. Just wanted to ask if there already are solutions for this or any approaches you would like to do in order to resolve the issue. I think there might be many more cases like the mentioned one.

@0utplay
Copy link
Author

0utplay commented May 13, 2024

Might be somehow related to #2920

@Jeppa
Copy link

Jeppa commented May 13, 2024

Also mentioned here #2913 and here #2669 (comment)

EuSouVoce added a commit to EuSouVoce/ProtocolLib-paper that referenced this issue May 13, 2024
@PukPukov
Copy link

Visiblity

Again paper using windows notepad to write code and pushes fucking typo that breaks everything.

@dawon
Copy link

dawon commented May 14, 2024

Since Paper uses mojang mappings, I would say this typo was made by mojang...

@0utplay
Copy link
Author

0utplay commented May 14, 2024

The typo being there or not is not the real issue 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants