Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering a Listener for SET_PROTOCOL Blocks Players From Logging In #2647

Closed
1 task done
LOOHP opened this issue Nov 23, 2023 · 1 comment · Fixed by #2933
Closed
1 task done

Registering a Listener for SET_PROTOCOL Blocks Players From Logging In #2647

LOOHP opened this issue Nov 23, 2023 · 1 comment · Fixed by #2933

Comments

@LOOHP
Copy link
Contributor

LOOHP commented Nov 23, 2023

  • This issue is not solved in a development build

Describe the bug
Simply registering a packet listener for the PacketType.Handshake.Client.SET_PROTOCOL blocks players from logging in (they get stuck when the client shows Encrypting until timeout), this is tested in 1.20.2 & 1.20.6.

ProtocolLibrary.getProtocolManager().addPacketListener(new PacketAdapter(PacketAdapter.params().optionAsync().plugin(InteractiveChat.plugin).types(PacketType.Handshake.Client.SET_PROTOCOL)) {
    @Override
    public void onPacketReceiving(PacketEvent event) {
        //This never gets called, even while the player is stuck.
        //So what's in here or whether there's anything here does not matter.
    }
});

It does not matter if optionAsync() is present or not.

To Reproduce

  1. Register the listener as shown in the code above
  2. Install the plugin, boot the server
  3. Try to login

Expected behavior
Being able to login as usual

Version Info
https://pastebin.com/y95HYpkb

@LOOHP
Copy link
Contributor Author

LOOHP commented May 15, 2024

Update: This issue is still present in 1.20.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant