Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to active menu item on mobile, doesn't work as it did in v9 #2134

Open
langz opened this issue Mar 22, 2023 · 1 comment
Open

Scroll to active menu item on mobile, doesn't work as it did in v9 #2134

langz opened this issue Mar 22, 2023 · 1 comment

Comments

@langz
Copy link
Contributor

langz commented Mar 22, 2023

When going to docs(subpages) like /uilib/components/accordion/demos/ (https://deploy-preview-2120--eufemia.netlify.app/uilib/components/accordion/demos/) and then pressing the hamburger/馃崝 /sidebar-icon, it doesn't scroll to the active/correct menu item. See the following video:

Screen.Recording.2023-03-22.at.10.53.53.mov

I would expect that it works as in v9, seen at https://eufemia.dnb.no/
So that when visiting the demos tab of accordion and pressing the hamburger-icon, I would expect to be "auto scrolled" to the active item(Accordion) in the menu.
See the following video:

Screen.Recording.2023-03-22.at.10.56.02.mov

Not sure if the cause of this is #2063 or #2120 馃
Could be somewhere else as well 馃槀

@langz langz changed the title Scroll to menu item on mobile, doesn't work as it did in v9 Scroll to active menu item on mobile, doesn't work as it did in v9 Mar 22, 2023
@joakbjerk
Copy link
Contributor

Yeah I noticed some issues with the scrolling there myself when working on #2063. I did test it on the v10 without the changes from #2063 and there was still some issues with the alignment of the active menu item after scrolling, so that issue at least happened some time after starting on v10, but before #2063. I made a jira task back then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants