[CHORE] 유저 관련된 API 통일 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-jungbin
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
궁금한 게 MyService에는 MyViewModel, EditViewModel이 있는데 파일명은 MyService라고 지으신 이유가 있나요??
그리고, 하나의 API 서비스 함수 당 꼭 하나의 뷰모델이 대응되어야 하는 건가용??
파일 합치는 건 함수 하나당 하나의 뷰모델이 대응대는 형태 때문에 고민이 되는 것 같아요..! + 네이밍
꼭 코드의 형태(??)가 같아야만 클래스를 합칠 수 있는 건 아닌 것 같습니당..!! 기본적으로 목적에 따라 분류하던 거라서요!
|
API 가져다 쓸 때 그렇게 하는게 좋아서 그렇게 했었습니다..! 하나로 합칠 수 있다면 고민해 보겠습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업한 내용
🎶 PR Point
MemberRouter에MyRouter내용 넣었습니다! 그런데Service가 쓴 코드 형태가 비슷하면서 달라서? 합치는게 나을지 아니면 이건 지금처럼 따로 둘지 고민이 됩니다..관련 이슈