Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest user able to annotate #413

Closed
atakanokan opened this issue Oct 22, 2019 · 7 comments · May be fixed by #430
Closed

Guest user able to annotate #413

atakanokan opened this issue Oct 22, 2019 · 7 comments · May be fixed by #430

Comments

@atakanokan
Copy link

How to reproduce the behaviour

I created a guest user that only has the following permission + assigned to one project:
image

However, when I log in using this account, the user is still able to annotate. I want the guest user to be able to only view the annotations and nothing else.

Project Details

Collaborative annotation: True
Type: Sequence Labeling

Your Environment

  • Operating System: Linux on AWS
  • Python Version Used: 3.6.6
  • When you install doccano: Early september
  • How did you install doccano (Heroku button etc): From Docker image
@c-w
Copy link
Member

c-w commented Oct 22, 2019

Pull request #333 implements a proposal for a business-logic permission system for doccano. The roles we propose are "Annotator" (can annotate documents in a project) and "Annotation Approver" (can approve annotations in a project). Once the pull request is merged, adding a "Guest" or "Viewer" role should be fairly easy. cc @margaretmeehan

@Hironsan
Copy link
Member

Maybe solved in #333

@atakanokan
Copy link
Author

Definitely not solved in #333.

@c-w @margaretmeehan It seems that roles & groups in django are very different. There is no way to assign view-only capabilities to a 'Role' but it is capable to do that to a 'Group'. Can we reopen the issue?

@c-w
Copy link
Member

c-w commented Oct 29, 2019

We should be able to extend the role model introduced in #333 to add a "view only" role. A project admin can then invite users to projects and set their role as "view only" so that those users can only see data but not annotate it. This isn't implemented currently but should be a relatively small amount of effort. Would that work for your use-case?

@atakanokan
Copy link
Author

Yes, would work great! Thanks @c-w

@c-w
Copy link
Member

c-w commented Oct 30, 2019

See #430 @atakanokan

@atakanokan
Copy link
Author

atakanokan commented Oct 30, 2019

Looks really good! Hopefully will be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants