-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to pass --ssh
flag to the build
#123
Conversation
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
- Coverage 44.85% 44.03% -0.83%
==========================================
Files 3 3
Lines 107 109 +2
Branches 17 17
==========================================
Hits 48 48
- Misses 46 48 +2
Partials 13 13
Continue to review full report at Codecov.
|
Not sure if something like ssh agent socket makes sense in GH actions context. Maybe this should just take direct ssh key value from secrets and create a temp file to expose via |
That seems like it might be overcomplicating it and moving the action |
Sorry, I forgot this issue. I'm fine with this approach but looks like PR needs a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jesserockz Need rebase like @tonistiigi said and you also need to run a pre-checkin
. See https://github.com/docker/build-push-action/blob/master/.github/CONTRIBUTING.md#submitting-a-pull-request
Thanks guys. I will take a look at rebasing again on Monday as I merged master on Friday and it broke our deployments. |
Signed-off-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
I have rebased locally, but just waiting on a PR merge in our repo before I can push to the branch so it shows up here. |
Signed-off-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for merging. Any chance of a new tag/release so I can update our workflows? @crazy-max @tonistiigi |
@jesserockz A new release will be created tomorrow. |
Closes #39