Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network input #338

Merged
merged 1 commit into from Apr 6, 2021
Merged

Add network input #338

merged 1 commit into from Apr 6, 2021

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Apr 6, 2021

Fixes #317

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review April 6, 2021 12:51
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should not promote this. We can still add it for backward compatibility. Usually, this is the wrong pattern to use. User should do RUN --network=host in Dockerfile and set entitlement instead.

@crazy-max crazy-max merged commit e1b7f96 into docker:master Apr 6, 2021
@crazy-max crazy-max deleted the network branch April 6, 2021 21:43
@crazy-max
Copy link
Member Author

@tonistiigi

I wonder if we should not promote this. We can still add it for backward compatibility. Usually, this is the wrong pattern to use. User should do RUN --network=host in Dockerfile and set entitlement instead.

Yes, indeed, it would make more sense to do it that way.

Copy link

@akay222 akay222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mookie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for --network option when build
3 participants