use Octokit client to download buildx

[crazy-max]

fixes #190

[rmg]

Using @actions/github for this will break GH enterprise usage because it would try to download the release from the GH enterprise server it is running on instead of github.com

[crazy-max]

@rmg So needs to enforce server url in octokit?

[crazy-max]

@rmg You mean https://github.com/actions/toolkit/tree/main/packages/github#usage?:

Returns an authenticated Octokit client that follows the machine proxy settings and correctly sets GHES base urls. See https://octokit.github.io/rest.js for the API.

That doesn't look to be related

[rmg]

Having it as an input is good, but making the default a little smarter would be good, eg: from actions/setup-go:action.yml:

  token:
    description: Used to pull node distributions from go-versions. Since there's a default, this is typically not supplied by the user. When running this action on github.com, the default value is sufficient. When running on GHES, you can pass a personal access token for github.com if you are experiencing rate limiting.
    default: ${{ github.server_url == 'https://github.com' && github.token || '' }}

[rmg]

@actions/github creates the client using process.env['GITHUB_API_URL'] which will be different on GHES.

[tonistiigi]

@rmg Is there a place where we can hardcode it to api.github.com on initialization?

[crazy-max]

I think with:

      .getOctokit(githubToken, {
        baseUrl: config.GITHUB_API_URL
      })

[crazy-max]

@rmg Ah yes just found actions/toolkit#449

[rmg]

FWIW it took GitHub a few tries to get this right for their own actions: https://github.com/actions/setup-python/pulls?q=is%3Apr+token+is%3Aclosed