-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cli_home volume whenever cli image version is updated #787
Comments
We already instruct users in docs to do The issues is that this stopped working after Looks like, we'll need a special handling for |
Not sure what activities left here but it is in the ToDo column for 1.12. |
This is still a valid issue when the docksal/cli version is updated in the default stacks (like with the 1.11 release, actually). When this happens, |
cli_home
is an anonymous volume mounted in thecli
service:docksal/stacks/services.yml
Line 91 in a7fc935
It was introduced to optimize write heavy operations in
/home/docker
insidecli
. See #325When a docker compose service configuration (including the image) is updated, volumes are not dropped and are remounted as-is. This is usually desirable, e.g., when updating the
db
service settings, the database(s) date volume is preserved.In the case of
cli
, however, we do want thecli_home
volume dropped. That is because this volume contains a bunch of tools and configs that tend to change from onedocksal/cli
version to another. Without dropping it, the update won't be complete and will miss the changes in/home/docker
.At the same time (and ideally) we don't won't to drop the volume on EVERY configuration update to the
cli
service. Only image version changes requirecli_home
to be dropped, which makes this somewhat complicated, since we currently do not have a reliable way to track stack configuration changes.The text was updated successfully, but these errors were encountered: