Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEXT] Docsify v5 #1061

Closed
anikethsaha opened this issue Mar 10, 2020 · 33 comments
Closed

[NEXT] Docsify v5 #1061

anikethsaha opened this issue Mar 10, 2020 · 33 comments
Labels
pinned This is to pinned the PR/Issue in order to keep it open

Comments

@anikethsaha
Copy link
Member

anikethsaha commented Mar 10, 2020

New Features To be included (see also 5.0! project board)

1. Static HTML Generation (non-blocking)

2. New markdown Helpers (Needs a list to track)

3. Better executable code syntax in MD

4. Docsify-themeable

status PR

Docsify currently offers four official themes: vue, buble, dark, and pure. These themes are all more-or-less the same with the exception of a handful of basic style declarations (color, typography, margin/padding, etc). To make development easier, a CSS preprocessor (stylus) is used to compile each theme by combining a shared CSS file with a theme-specific CSS file. Makes sense.

Docsify-themeable takes a similar approach but offers a much more flexible implementation by leveraging CSS custom properties. The end-user pitch is available on the introduction page, but the approach also provides advantages for docsify maintainers: a single block of CSS used for all themes, with each theme comprised of only a flat list of named values (e.g. --sidebar-background: #ccc) instead of blocks of CSS. Legacy support is also available courtesy of css-vars-ponyfill (which I created specifically for docsify-themeable).

5. Starter packs (CLI)

6. Change the pre-processor for css

7. Migrate to webpack

Feedback/Suggestion/Recommending more changes

Feel free to leave feedback, and suggestion for the above features
Plus, Leave a comment if you want to add some more features. We can have a discussion about that.

cc @docsifyjs/cli @docsifyjs/contributors @docsifyjs/core

@anikethsaha anikethsaha pinned this issue Mar 10, 2020
@anikethsaha anikethsaha mentioned this issue Mar 10, 2020
8 tasks
@QingWei-Li
Copy link
Member

QingWei-Li commented Mar 10, 2020

I can create a fresh PR if a new version starts development.

@anikethsaha
Copy link
Member Author

I can create a fresh PR if a new version starts development.

Coool. I guess that would fit best ! 💯

@alexellis
Copy link

I was impressed with the experience and how fast it was to make something useful -> https://docs.inlets.dev/, but I could really use a static generator to create HTML.

That means: getting permalinks and proper folders i..e /tutorials/k8s/that-one and being able to have the site scraped because it's rendering HTML and served from anywhere.

Looking forward to testing out the new release.

@anikethsaha
Copy link
Member Author

anikethsaha commented Mar 13, 2020

Thanks for the heads up 💯

That means: getting permalinks and proper folders i..e /tutorials/k8s/that-one and being able to have the site scraped because it's rendering HTML and served from anywhere.

I do think we have a focus that includes this.

Looking forward to testing out the new release.

Though I cant assure anyone when the work will begin and when it will be ready for release.
But we will try to get it ASAP.
👍

@jhildenbiddle
Copy link
Member

Happy to dive back in and help with the integration of docsify-themeable. I’m not sure what the timeline or preferred approach is though, so any guidance from the more active maintainers is welcome.

@anikethsaha
Copy link
Member Author

Happy to dive back in and help with the integration of docsify-themeable

Awesome

I’m not sure what the timeline or preferred approach is though

I don't think there is any timeline as of now. about docsify-themeable, I am not familiar with the library so I think we can discuss that in gitter and proceed with your old approach which you planned.

@jhildenbiddle
Copy link
Member

Sounds good, @anikethsaha.

@s-pace
Copy link

s-pace commented Apr 1, 2020

🎉 Do you want use to help you with search? I am part of the docsearch team https://docsearch.algolia.com/

@anikethsaha
Copy link
Member Author

That would be really great to have it as official plugin or external. Let me know how you would like to proceed . !

@s-pace
Copy link

s-pace commented Apr 1, 2020

Great. We will make sure to have the correct need:

All of theme will help the SEO too

@anikethsaha
Copy link
Member Author

With plugins we cant do this but we can add a section in our docs.

it can be with plugin

@s-pace
Copy link

s-pace commented Apr 1, 2020

What is the default elements used then instead of <article/> ? We would need some steady class otherwise.

@anikethsaha
Copy link
Member Author

the current search bar is placed in sidebar which is placed in aside. You can check the code for current search plugin here.

  • Sidebar is in aside with .sidebar class (steady)
  • the main content is placed in section.content . (steady)
  • Navbar in nav.app-nav.

If you want to keep the search bar in position where the current one is placed, I think that may not be the clear and complete visibility space for the search result.

This is the current search results

image

so either you can bring our the search result or place the search bar at the top in the navbar .

I think its better to be in navbar and we can take docusaurus@2's sidebar + navbar layout for reference

@anikethsaha
Copy link
Member Author

Also, we will remove the current dark mode button and it will be added through the core in the navbar

@s-pace
Copy link

s-pace commented Apr 2, 2020

Glad to ear.

We are working on an amazing new discovery experience with the search so stay tuned (Spoiler, @francoischalifour and @Shipow are on 🔥) .

I will be happy to help on that and make the process really smooth for Docsify users

@sy-records
Copy link
Member

sy-records commented Apr 4, 2020

For website SEO, we need Static HTML Generation. 👍🏻

ssr not working, like docsifyjs/docsify-ssr-demo#3 and docsifyjs/docsify-cli#95

@anikethsaha
Copy link
Member Author

It is a candidate for v5.

@jhildenbiddle
Copy link
Member

Thoughts regarding helpers added to #413.

(Apologies in advance for the lengthy post.)

@anikethsaha
Copy link
Member Author

There are few issues with static site generation as we support plugins which kind of does a lot (search bar, pagination etc.). without dom, we cant do it. I am thinking of having jsdom to run the plugins in node but still, I think it won't be consistent. Need second thought about it and also feel free to suggest some better solution for this.

@gisforgabriel
Copy link

For running search on a static generated site, a library like https://lunrjs.com/ could be a good option.

An index could be created when running docsify-cli and Lunr could power the sidebar search instead.

It would probably not be as performant or sophisticated as DocSearch, but it would offer a "proper" static experience - probably the kind of compromise that people who would be interested in the SSG option would prefer (if they're anything like me 😉).

That said, having third party search as another option would also be cool 👍

@Jacky2

This comment has been minimized.

@anikethsaha

This comment has been minimized.

@trusktr
Copy link
Member

trusktr commented May 10, 2020

Is there an issue tracking 3. Better executable code syntax in MD?

@trusktr
Copy link
Member

trusktr commented May 10, 2020

@anikethsaha I converted some of the above into their own issues, so that we can track them in the 5.0 project board. I assigned you to them just so you're aware / triage.

@trusktr trusktr mentioned this issue May 10, 2020
5 tasks
@trusktr
Copy link
Member

trusktr commented May 10, 2020

I updated the issues, and I gave them all labels like PoC Welcome, PR Welcome, needs discussion, etc, to match what we had here. It will be easier to manage it that way, and to have separate conversations in each one while also seeing the respective cards inside the 5.0! project board.

We could copy the shields back over here, but then that's more work to keep in sync. I think it would be best to rely on the labels, for easier sorting in the issue list or inside the project board, etc.

The labels are a nice visual in the project board and issue lists too.

@jhildenbiddle
Copy link
Member

jhildenbiddle commented Jun 10, 2020

Another v5 feature we should consider is tweaking the docisfy plugin architecture to be more resilient. This warrants further discussion, but here are two ideas worth considering:

  1. Provide a docisfy plugin "starter" or a sample repo to use as a starting point.

    This would make life much easier for the community and help enforce acceptance criters (below).

  2. Define acceptance criteria for all docsify plugins.

    This is critical for docsify because unlike static sites, a docsify-powered site requires Javascript to render content. If a docsify plugin throws an error, it is almost certain that site functionality will be broken.

    Here are a few idea for acceptance criteria:

    • Specify the version of ECMAScript plugin developers should target. For docsify v4.x, ES5 is the required target to ensure IE11 support. This means dev must either author their plugin with ES5 syntax or transpile their code from ES6+ to ES5. For docsify v5, we'll have to look at our supported browser list to determine the appropriate ECMAScript version to target.
    • Plugin code must be wrapped in a try { ... } catch(err) { ...} statement to prevent a plugin error from breaking a site.
    • Plugins must make their version number accessible to other plugins for interoperability. Docsify addons like docsify-themeable and docsify-tabs already do this by adding an object to the global $doscify object ($docsify.tabs and $docsify.themeable) with a version key and value. The goal is to allow both docsify and other plugins to determine which plugins are active and, if necessary, modify their behavior as needed.
    • Plugins must specify a compatible docsify version to prevent breaking sites when a new version of docsify is released. For example, consider a v4 site that is configured to load the latest version of docsify and multiple plugins. If docsify v5 is released using the same URLs, the v4 site will automatically be "upgraded" to v5 but will likely break as a result of trying to load v4 plugins. This safeguard would allow docsify (or the plugin itself) to determine if it is safe to run the plugin before doing so, which would at least allow the site to load and function properly (albeit without incompatible plugin functionality). This wouldn't be necessary if users locked their docsify, theme, and plugin CDN URLs to a major version (see Specify major version number in URLs #780), but since they don't a safeguard like this is necessary.

Just some ideas to get started.

@jthegedus
Copy link
Contributor

jthegedus commented Jun 10, 2020

@jhildenbiddle re 1: I have a plugin template repo I have yet to publicize. I will see about moving it to this org and then we can iterate on it.

@anikethsaha
Copy link
Member Author

@jhildenbiddle this is really an awesome suggestion. It would make the plugin integration much more strong and simple.

May be we should extract this suggestion into a new issue.

My 2 cents ⬇️

Also, I am thinking of creating a wrapper function something like this createDocsifyPlugin function that needs to be returned from the plugin. It will accepts the following data

interface PluginMetaI {
  version: String;
  docsifyVersion: String;
  polyfillURL?: String;
  definition(hook: Object): void;
  pluginDocsURL?: string;

  // SOme more meta datas,/
}

const createDocsifyPlugin = (PluginData: PluginMetaI): Promise<void> => {
  const { version, docsifyVersion, polyfillUrl, definition } = PluginData;

  // some validation of the datas
  // like loading the polyfill

  // ...

  return new Promise((res, rej) => {
    try {
      res(definition(hook));
    } catch (err) {
      rej(err);
    }
  });
};

export default createDocsifyPlugin({
  version: "4",
  docsifyVersion: "4.11.0", //minimum this version is required.
  definition: hook => {
    hook.beforeEach(function() {});
    // ...
  }
});

createDocsifyPlugin will be a global function I guess so that inline plugins can be returned as well.
I used promise so that we can handle the async and errors better.

This is just an example I am thinking of the implementation. We can discuss this for a better approach.

@jhildenbiddle
Copy link
Member

Plugin / wrapper discussion moved to #1209.

@stale
Copy link

stale bot commented Aug 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 10, 2020
@anikethsaha anikethsaha added pinned This is to pinned the PR/Issue in order to keep it open and removed wontfix labels Aug 10, 2020
@EternalDeiwos
Copy link

@anikethsaha You mentioned possibly using markdown-it as the markdown parser in #823 -- is this still being considered because that would be fantastic. It would be really great to have a pluggable parser.

@trusktr
Copy link
Member

trusktr commented Dec 8, 2021

Rather than try to pile a lot of things for a huge release, which we don't have time for, let's release features when as we go, more organically.

None of the major bullet points listed in the original post are breaking changes, but feature additions, which don't require a breaking change.

If we have an idea for any change that improves Docsify, we can make an issue or discussion for it, then a pull request if we think the change is worth it, including the appropriate version bump for it whether it is a patch, minor, or major.

By following this approach, we can keep making progress and not stalling a bag full of ideas for one huge major version bump. All of the original points can technically be added in v4.

As a general rule, let's try to keep backwards compatibility as much as we can.

So, I will close this, and let's open specific topics, and try to avoid breaks if possible unless something needs to change to improve end users experience.

@trusktr trusktr closed this as completed Dec 8, 2021
@trusktr
Copy link
Member

trusktr commented Dec 8, 2021

I forgot to mention, after getting things moving and making meaningful changes and bumping as necessary, including major bumps, we will be in better shape to stabilize and have less major bumps.

We should publish a nice migration log that makes it easy for people to update. Three.js follows the above approach, and this is what their migration log looks like:

https://github.com/mrdoob/three.js/wiki/Migration-Guide

Let's take inspiration from this, and move forward.

Three.js doesn't even have patch or minor bumps, only major.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned This is to pinned the PR/Issue in order to keep it open
Projects
None yet
Development

No branches or pull requests