Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Search plugin: matched text is replaced with search text #1298

Merged
merged 6 commits into from Jul 24, 2020

Conversation

huangzhhui
Copy link
Contributor

@huangzhhui huangzhhui commented Jul 21, 2020

Summary

Fixed #529

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Jul 21, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/n1442tnwv
✅ Preview: https://docsify-preview-git-fork-huangzhhui-develop.docsify-core.vercel.app

@huangzhhui huangzhhui changed the title Fix search plugin will replace matching text fix #529 Jul 21, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 21, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de431cb:

Sandbox Source
docsify-template Configuration

sy-records
sy-records previously approved these changes Jul 21, 2020
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally it seems fine.:+1:.

But when the matched content has more than one keyword matched, it seems would replace themselves. i.e. search example in Example...and the example is..,
the results should be like ...Example...and the Example is..

@sy-records
Copy link
Member

image

@vercel vercel bot temporarily deployed to Preview July 22, 2020 12:04 Inactive
@Koooooo-7
Copy link
Member

thx for ur input ! 👍
It still cant solve the case as I mentioned above.
There is a fix also #1304 . if possible, glad to get more ideal solutions.

@huangzhhui
Copy link
Contributor Author

thx for ur input ! 👍
It still cant solve the case as I mentioned above.
There is a fix also #1304 . if possible, glad to get more ideal solutions.

Sorry, I misunderstanding your case, I had fixed it up.
image

Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool ! Even though it will duplicated replace some times, it is acceptable.
LGTM. 💯

Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sy-records sy-records changed the title fix #529 fix: Search plugin: matched text is replaced with search text Jul 24, 2020
@sy-records sy-records merged commit 78775b6 into docsifyjs:develop Jul 24, 2020
@sy-records sy-records mentioned this pull request Aug 18, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search plugin: matched text is replaced with search text
4 participants