Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing navbar with only coverpage #1696

Open
1 task done
CxRes opened this issue Dec 27, 2021 · 6 comments · May be fixed by #1706
Open
1 task done

Missing navbar with only coverpage #1696

CxRes opened this issue Dec 27, 2021 · 6 comments · May be fixed by #1706

Comments

@CxRes
Copy link

CxRes commented Dec 27, 2021 •
edited

Bug Report

Steps to reproduce

  1. Set a navbar loadnavbar: "_nav.md".
  2. Set onlyCover: true

What is current behaviour

The navbar is missing on first navigation to the page.

What is the expected behaviour

The navbar should exist unless set to false.

Other relevant information

If you go to an internal page and and

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Windows 10 x64

  • Node.js version: 14.17.5

  • npm/yarn version: 6.14.14

  • Browser version: Brave Version 1.33.106 Chromium: 96.0.4664.110 (Official Build) (64-bit)

  • Docsify version: 4.12.1

  • Docsify plugins: NA

Please create a reproducible sandbox

Edit 307qqv236

Sandbox link: https://codesandbox.io/s/elated-sound-6s1rq

Mention the docsify version in which this bug was not present (if any)
@trusktr
Copy link
Member

trusktr commented Dec 28, 2021

@CxRes can you please provide a working reproduction? See the codesandbox link above.

@trusktr
Copy link
Member

trusktr commented Dec 28, 2021

Wait, nvm, i see the second link. The first one pointed to the default sandbox.

@trusktr
Copy link
Member

trusktr commented Dec 28, 2021

In your reproduction, there is no buttons on the cover page to go to any other page. I believe the expectation is that you will link to a page, then you will see a navbar on that page. Or no?

Does this work on any other sites?

If not, this may be a feature request. We could add an option to show navbar on cover-only pages (defaulting to false to be backward compatible).

PRs welcome!

@CxRes
Copy link
Author

CxRes commented Dec 28, 2021

@trusktr I added a button in the reproduction. There is no effect.

This is not a feature request! It is a BUG!!!

@trusktr
Copy link
Member

trusktr commented Dec 31, 2021 •
edited

I'm not sure if this ever worked. I tried searching github for "onlyCover true" and you can see there are only 5 results and they have a typo (onlycover instead of onlyCover).

We should have this ability regardless if its a bug or not.

@trusktr trusktr linked a pull request Dec 31, 2021 that will close this issue
Open
9 tasks
@trusktr
Copy link
Member

trusktr commented Dec 31, 2021 •
edited

pull request: #1706 (needs a test added for the feature)

@docsifyjs docsifyjs locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add an option to render the navbar when onlyCover is true docsifyjs/docsify
2 participants
@trusktr @CxRes