Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed more video render sidar menu more times #2049

Open
1 task
wideweide opened this issue Apr 27, 2023 · 4 comments
Open
1 task

embed more video render sidar menu more times #2049

wideweide opened this issue Apr 27, 2023 · 4 comments

Comments

@wideweide
Copy link

Bug Report

Steps to reproduce

# More video

## video 1
![video](video/1.mp4 ':include :type=video width=95% controls=controls ')

## video 2
![video](video/2.mp4 ':include :type=video width=95% controls=controls ')


## video 3
![video](video/3.mp4 ':include :type=video width=95% controls=controls ')

What is current behaviour

side bar is like this:

More video
    - video 1
    - video 2
    - video 3
    - More video
       -  video 1
        - video 2
        - video 3
    - More video
        - video 1
        - video 2
        - video 3

What is the expected behaviour

side bar is like this:

More video
    - video 1
    - video 2
    - video 3

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Pop!_OS 22.04 LTS

  • Node.js version: v18.15.0

  • npm/yarn version: 9.5.0

  • Browser version: firefox 112.0.1

  • Docsify version: //cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js

  • Docsify plugins:

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

@wideweide
Copy link
Author

ps:
if video/1.mp4 is not exists, just not show the video
replace with real url that can be visited, can reproduce my issue

@Koooooo-7
Copy link
Member

Related to issue #1822 and pr in #1824 .

@wideweide
Copy link
Author

Related to issue #1822 and pr in #1824 .

I'm a newbie, so how can I use the pr to solve my issue?

@Koooooo-7
Copy link
Member

Related to issue #1822 and pr in #1824 .

I'm a newbie, so how can I use the pr to solve my issue?

Basically, I think it is not a good way to build ur own docsify dependency. and I think we need get this fix and release a path asap.

cc @docsifyjs/reviewers , PTAL at #1824.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants