Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missed to copy files in docker image when building Dockerfile #2412

Closed
1 task
joker7blue opened this issue Apr 26, 2024 · 2 comments
Closed
1 task

missed to copy files in docker image when building Dockerfile #2412

joker7blue opened this issue Apr 26, 2024 · 2 comments

Comments

@joker7blue
Copy link

Bug Report

missing COPY . . in docker file

Steps to reproduce

  • Go to https://docsify.js.org/#/deploy
  • Scroll docker to docker part (Create Dockerfile)
  • Copy the suggested docsify Dockerfile
  • Go to yor docsify project, and paste what you copied from docsify website into your project
  • have a docker installed to you machine
  • have docsify installed
  • have a docsify project

Current behaviour

The files are not copied to the docker image when building docker file, since we missed to COPY . .

Expected behaviour

The docsify project should run as expected after building from docker

Other relevant information

  • Docsify version: latest
  • Bug still occurs when all/other plugins are disabled?

  • Docsify plugins (if the bug happens when plugins enabled, please try to isolate the issue):

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

@Koooooo-7
Copy link
Member

Hi @joker7blue , it doesn't copy it into the Dockerfile, it mounts the files as volume instead. Hence, you can sync the live changes on time.

docker run -itp 3000:3000 --name=docsify -v $(pwd):/docs docsify/demo

If you wanna deploy your site via docker, either you put all your things inside the Docker image or mount it on runtime, thats both okay.

@joker7blue
Copy link
Author

oh ok, Thanks for the explanation @Koooooo-7 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants