Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DoctrineTransportFactory.php bad implementation #1062

Closed
onavascuez opened this issue Nov 21, 2019 · 4 comments
Closed

DoctrineTransportFactory.php bad implementation #1062

onavascuez opened this issue Nov 21, 2019 · 4 comments
Labels
Bug
Milestone
2.0.1

Comments

@onavascuez
Copy link

onavascuez commented Nov 21, 2019 •
edited

Just yesterday I was updated my project, and some packages includes new DoctrineBundle 2.0.0, and I was found this error:

In DoctrineTransportFactory.php line 29:
                                                                               
  Argument 1 passed to Symfony\Component\Messenger\Transport\Doctrine\Doctrin  
  eTransportFactory::__construct() must be an instance of Symfony\Bridge\Doct  
  rine\RegistryInterface, instance of Doctrine\Bundle\DoctrineBundle\Registry  
   given, called in /builds/php/bcn/svc-pre-booking-manager/var/cache/test/Co  
  ntainerGv2wPhF/getMessenger_Transport_Doctrine_FactoryService.php on line 1  
  2

New Registry doesn't have implementation of RegistryInterface causing this fail.
@alcaeus alcaeus added the Bug label Nov 21, 2019
@alcaeus alcaeus added this to the 2.0.1 milestone Nov 21, 2019
@dmaicher
Copy link
Contributor

@alcaeus so I guess symfony/messenger 4.3 is incompatible with DoctrineBundle 2?

https://github.com/symfony/symfony/blob/4.3/src/Symfony/Component/Messenger/Transport/Doctrine/DoctrineTransportFactory.php#L29

This was referenced Nov 22, 2019
Closed
Merged
fabpot added a commit to symfony/symfony that referenced this issue Nov 22, 2019
@fabpot
minor #34517 [Messenger] compatibility with DoctrineBundle 2 (xabbuh)
860f96c 
This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] compatibility with DoctrineBundle 2

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34514, doctrine/DoctrineBundle#1062
| License       | MIT
| Doc PR        |

Commits
-------

6ff20f0 compatibility with DoctrineBundle 2
@xabbuh
Copy link
Member

xabbuh commented Nov 22, 2019

fixed in symfony/symfony#34517

@xabbuh xabbuh closed this as completed Nov 22, 2019
@doctrinebot doctrinebot mentioned this issue Nov 28, 2019
Closed
@malorentelopez
Copy link

Hi all,

I'm having the same issue even with DoctrineBundle v2.0.2 and Symfony in v4.3.8.

Regards,

MA

@stof
Copy link
Member

stof commented Nov 28, 2019

@malorentelopez the fix in Symfony is not released yet. You will need to use the dev version of 4.3 for now (it will be part of the next patch release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
6 participants
@onavascuez @alcaeus @stof @dmaicher @xabbuh @malorentelopez