Deprecate .class parameters #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting this on hold: there were some class parameters that were necessary due to the Doctrine Bridge, otherwise they would've been removed in 2.0 already. We'll check that out separately, but for now those don't hurt anyways. |
|
Doctrine bridge PR was merged right? It's possible something was missed there? |
|
@alcaeus Can you elaborate what more needs to be done in Doctrine Bridge, or what is blocking this? |
|
So the bridge is still using the class parameters for cache, but that code shouldn't be called anymore. I thought there were more but I'm not seeing them, so we could just remove all of them and see if anything breaks 🤷♂️ |
|
So we can merge this? |
alcaeus
added
Documentation
and removed
Status: On Hold
alcaeus
approved these changes
Feb 4, 2020
|
Thanks @ostrolucky! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #949.
Btw I was trying to find how other people deprecated this and found that nobody actually did, not even Symfony. Not even with readme entry, like we are doing here.