Replace unmaintained SQL formatter dependency #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
drop-unmaintained-dependency
branch
from
da86a35
to
b4d75bd
Compare
greg0ire
commented
May 22, 2020
Twig/DoctrineExtension.php
Outdated
| HtmlHighlighter::HIGHLIGHT_ERROR => 'class="error"', | ||
| HtmlHighlighter::HIGHLIGHT_COMMENT => 'class="comment"', | ||
| HtmlHighlighter::HIGHLIGHT_VARIABLE => 'class="variable"', | ||
| ], false)); |
There was a problem hiding this comment.
With this change, I make the assumption that this isn't used in the CLI context. This allows us to add some tests.
|
I'm not sure it's ok to merge this into 1.12. I think at least @alcaeus would mind that. And I'm also leaning to merge this for master only, it might be too risky to do it in 1.12 while we don't have problems with current formatter. If we had some problems, eg. with php 8 compatibility, then I would be fully on board with this. |
|
I'd advocate to only merge this into 2.1 for the upcoming release. |
greg0ire
force-pushed
the
drop-unmaintained-dependency
branch
from
b4d75bd
to
5f63db6
Compare
|
Fine by me. |
greg0ire
force-pushed
the
drop-unmaintained-dependency
branch
from
5f63db6
to
1d1fc3e
Compare
ostrolucky
requested changes
May 22, 2020
greg0ire
force-pushed
the
drop-unmaintained-dependency
branch
from
1d1fc3e
to
108292b
Compare
ostrolucky
approved these changes
May 22, 2020
alcaeus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #785