Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DbalExecutor depends on concrete connection #1312

Closed
ro0NL opened this issue Jan 20, 2023 · 0 comments
Closed

DbalExecutor depends on concrete connection #1312

ro0NL opened this issue Jan 20, 2023 · 0 comments

Comments

@ro0NL
Copy link

ro0NL commented Jan 20, 2023

See #906 (comment) for background.

We currently copy/pasted DbalExecutor to handle ALTER queries via Percona Toolkit: https://docs.percona.com/percona-toolkit/pt-online-schema-change.html

The copy/paste broke today due updated upstream.

Ideally we pass a decorated connection to DbalExecutor, to handle ALTER queries as such.

@ro0NL ro0NL closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant