Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input validation to all input fields #950

Open
6 tasks done
teyim opened this issue Feb 20, 2024 · 4 comments · May be fixed by #1162
Open
6 tasks done

Add input validation to all input fields #950

teyim opened this issue Feb 20, 2024 · 4 comments · May be fixed by #1162
Assignees
@teyim
Labels
Stale status: assigned Issue has been assigned type: bug Something isn't working

Comments

@teyim
Copy link

teyim commented Feb 20, 2024 •
edited

Issue Description

Input fields do not have validation, allowing users to enter extremely lengthy text in input fields, causing the UI to break.

Steps to Reproduce

Enter very lengthy text in any input field

Expected Behavior

The input fields should be validated, limiting the number of characters allowed for a given input, ideally 16-32 chars depending on the input type

Current Behavior

No response

Screenshots (optional)

Screenshot from 2024-02-20 11-36-27

image

Operating System [e.g., Windows 10]

ubuntu

Browser [e.g., Chrome, Firefox]

Chrome

Version [e.g., 2.0.1]

No response

Please check the boxes that apply to this issue report.

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided steps to reproduce the issue.
  • I have included relevant environment information.
  • I have included any relevant screenshots.
  • I understand that this is a voluntary contribution and that there is no guarantee of resolution.
  • I want to work on creating a PR for this issue if approved
@teyim teyim added the type: bug Something isn't working label Feb 20, 2024
@github-actions github-actions bot added the status: triage Scope to be determined label Feb 20, 2024
@github-actions GitHub Actions
Copy link

Thank you for opening your first issue and for being a part of the open signing revolution!

One of our team members will review it and get back to you as soon as it possible 💚

Meanwhile, please feel free to hop into our community in Discord

@teyim
Copy link
Author

teyim commented Feb 20, 2024 •
edited

Will like to work on this

@Mythie
Copy link
Collaborator

Mythie commented Feb 20, 2024

Hey there, I reckon this is less to do with input validation and more to do with handling word-breaks and truncating text more effectively!

Long names can exist and so we should account for that gracefully instead of blocking it 😄

If you'd like to make some css/styling tweaks to accommodate these situations better I'd be happy to assign you 🔥

@teyim
Copy link
Author

teyim commented Feb 20, 2024

ok @Mythie, please assign this to me, would like to work on it.

@Mythie Mythie added status: assigned Issue has been assigned and removed status: triage Scope to be determined labels Feb 20, 2024
@rhit-daviscl rhit-daviscl linked a pull request May 16, 2024 that will close this issue
Open
5 tasks
@github-actions github-actions bot added the Stale label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teyim teyim

Labels
Stale status: assigned Issue has been assigned type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: truncation of titles to fix UI breaks rhit-daviscl/documenso
2 participants
@Mythie @teyim