Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple payout targets #113

Open
tjstebbing opened this issue Sep 11, 2023 · 4 comments
Open

Multiple payout targets #113

tjstebbing opened this issue Sep 11, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@tjstebbing
Copy link
Contributor

Being able to payout in a single transaction to multiple addresses enables the 'fee for processing' usecase where a provider of GigaWallet (as a payment service) wants n% or a fixed amount of doge to go to their own address on payout.

Suggestion:

was:

POST /account/:foreignID/pay { "amount": "1.0", "to": "DPeTgZm7LabnmFTJkAPfADkwiKreEMmzio" } -> { status }

POST /account/:foreignID/pay { "DPeTgZm7LabnmFTJkAPfADkwiKreEMmzio" : "1.0", ... } -> { status }

How does fee work for payout?

@raffecat
Copy link
Contributor

I think the payments should be in a field, like:

{ "pay": { "DPeTgZm7LabnmFTJkAPfADkwiKreEMmzio" : "1.0", ... } }

So then we can extend the arguments like:

{ "deduct_fee": true, "pay": { "DPeTgZm7LabnmFTJkAPfADkwiKreEMmzio" : "1.0", ... } }

@tjstebbing
Copy link
Contributor Author

tjstebbing commented Sep 11, 2023

{ 
  "explicit_fee" :  "0.02" // optional
  "pay":  [
   { 
     "to": "DPeTgZm7LabnmFTJkAPfADkwiKreEMmzio",
     "amount" : "1.0",
     "deduct_fee_percent" :  "100", // optional
   },
   { 
     "to": "kAPfADkwiKreEMmzioDPeTgZm7LabnmFTJ",
     "amount" : "100.0",
   },
     
   ],
   
} 

@raffecat
Copy link
Contributor

deduct_fee_percent?

@tjstebbing tjstebbing added the enhancement New feature or request label Sep 11, 2023
@georgeartem
Copy link

Personally I like the idea of being able to do both explicit fee and percentage allowing the implementer to choose.

raffecat added a commit that referenced this issue Oct 2, 2023
raffecat added a commit that referenced this issue Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants