-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Expose HD public key derivation #155
Comments
so i just tested deriving ext pubkey from ext pubkey in the address tests and this worked fine for me:
the problem is we can't derive ext child pub keys from ext pubkeys because of hardening derivation standard stated in bip44, thus this one which more or less aligns with bip32 without hardening flags |
extra info re bip32:
|
@chromatic is this issue resolved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
Describe the Feature Request
BIP-44 private key derivation exists and works according to the tests. However, it'd be safer to expose extended public key derivation, such that users do not have to expose their public keys.
This code may work as it exists, so I might be asking for more complete documentation and testing.
Describe Preferred Solution
Just as
src/address.c
exposesgetHDAddress
by path and path components, expose similar functions which accept an extpub key instead.Related Code
I expect the code to work something like this:
Again, my simple reading of
src/address.c
makes me think that it works, but I'm not sure if I have the correct results to write tests.The text was updated successfully, but these errors were encountered: