Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DokanGetMountPointList - Return valid point for empty result #1109

Open
Liryna opened this issue Sep 11, 2022 · 1 comment
Open

DokanGetMountPointList - Return valid point for empty result #1109

Liryna opened this issue Sep 11, 2022 · 1 comment

Comments

@Liryna
Copy link
Member

Liryna commented Sep 11, 2022

From dokan-dev/dokan-rust#5 (comment) , we should have DokanGetMountPointList return a non NULL value for empty result to diff whether the function failed or not.

@KoltesDigital
Copy link
Contributor

I was thinking: if the value is non-null, DokanReleaseMountPointList must be called at some point. Therefore this function must recognize the magic value, and do nothing in this case. I believe this function isn't called so often, so performance overload is okay... but it just feels less classy.

Maybe a good old BOOL DOKANAPI DokanGetMountPointList(BOOL uncOnly, PDOKAN_MOUNT_POINT_INFO *outList, PULONG nbRead); would do the job and keep DokanReleaseMountPointList untouched, but this is kind of a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants