Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update png/gif icons #4155

Open
Klap-in opened this issue Jan 16, 2024 · 2 comments
Open

Update png/gif icons #4155

Klap-in opened this issue Jan 16, 2024 · 2 comments

Comments

@Klap-in
Copy link
Collaborator

Klap-in commented Jan 16, 2024

/lib/images/admin/

acl config plugin popularity revert styling usermanager
(Were old icons used on the admin page, but these are already replaced by svg icons included in the respectively plugin)

/lib/images/

blank.gif (blank.gif)
bullet.png =>
closed-rtl.png =>
closed.png =>
diff.png => (or )
email.png => (done)
error.png =>
external-link.png => (done)
history.png =>
icon-list.png =>
icon-sort.png => ( )
info.png =>
interwiki.png => (done)
larger.gif =>
magnifier.png => ( ) (used in media popup, show original image)
media_align_center.png =>
media_align_left.png =>
media_align_noalign.png =>
media_align_right.png =>
media_link_direct.png => no icon with image with link...
media_link_displaylnk.png =>
media_link_lnk.png =>
media_link_nolnk.png =>
media_size_large.png =>
media_size_medium.png =>
media_size_small.png =>
media_size_original.png =>
mediamanager.png => (used in media popup) (already available: lib/images/menu/folder-multiple-image.svg)
minus.gif =>
notify.png =>
ns.png => () (used in linkwizard)
open.png =>
page.png =>
plus.gif =>
resizecol.png => resize handle columns media manager, not found. Build self svg, todo
smaller.gif =>
success.png =>
throbber.gif =>
trash.png => (used in media popup)
unc.png => (done)
up.png => (used in linkwizard, up to parent symbol)
wrap.gif =>

/lib/tpl/dokuwiki/images

apple-touch-icon.png => (available)
button-css.png => self build, todo
button-donate.gif => self build, todo
button-dw.png => self build, todo
button-html5.png => self build, todo
button-php.gif => self build, todo
button-rss.png => self build, todo
logo.png =>
page-gradient.png => page-background.svg there is already svg, seems not used?
search.png =>
toc-arrows.png =>
toc-bullet.png =>
usertools.png => old, already svg
pagetools-sprite.png => (and subfolder /pagetools/, both not used anymore)

further:
favicon.ico favicon.ico

lib/plugins/acl/pix

user.png =>
group.png => ( )
ns.png => (see also above)
page.png => (see also above)

lib/plugins/config/images

danger.png => (see above)
security.png => ( )
warning.png =>

lib/plugins/extension/images

bug.gif => ()
down.png =>
tag.png => ()
warning.png =>
disabled.png =>
enabled.png =>
overlay.png => single pixel image
template.png => build self, todo
donate.png =>
plugin.png => build self, todo
up.png => (see also above)
also: icons.xcf

lib/plugins/usermanager/images

search.png => (see also above)

A couple of these images are used by plugins, but it would be nice to have more uniform icon usage. So it might be worth to include svg icons with DokuWiki instead of letting plugins search there own.

Suggestions from Material Design Icons are welcome (https://pictogrammers.com/library/mdi/).

Further also toolbar uses old icons. Probably #1204 (reference) contributions of Andi to MDI closes there the gap already significantly.

@Klap-in
Copy link
Collaborator Author

Klap-in commented Jan 19, 2024

For most icons now suggestions are added above from MDI. The sizes are sometimes a bit small. Needs probably quite often specific css for correct size. Also some colors are needed.

Any feedback on the suggestions?

@splitbrain
Copy link
Collaborator

Thanks for the list. The picks are a good start, we can always discuss/change certain choices in their respective PRs.

I thinks starting with the non-toolbar icons is easiest.

The toolbar is on my mental todo list of things that are in dire need of refactoring. The way it is currently built (especially when using wanting to execute custom code) is really not how modern JavaScript should work (with the need of declaring global methods with a specific name)... A refactoring is not strictly necessary for simply switching to SVG icons but might be beneficial. Regarding colors, I think color grouping toolbar icons might be helpful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants