Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing reject after maxAttempts #231

Open
BarrMan opened this issue Feb 9, 2022 · 1 comment
Open

Missing reject after maxAttempts #231

BarrMan opened this issue Feb 9, 2022 · 1 comment

Comments

@BarrMan
Copy link

BarrMan commented Feb 9, 2022

What Is the issue?

Missing reject after maxAttempts. Handshake keeps hanging when max attempts reached.

Provide issue context below using code examples, images, or links

When calling Postmate with Slow 3G/Fast 3G internet connection, the connection might not be established on time. The maximum time Postmate allows is 500ms * 5attempts which is 2.5 seconds. For slower connections it might not suffice. Rejecting the promise allows the user to use some sort of handling logic.

@BarrMan
Copy link
Author

BarrMan commented Feb 9, 2022

Fixed at: #230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant