Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make row optional in VALUES constructor and insert statement #344

Merged
merged 3 commits into from
May 14, 2024
Merged

Conversation

jycor
Copy link

@jycor jycor commented May 13, 2024

This PR adds additional syntax support for VALUE constructor.

fixes dolthub/dolt#6849
fixes dolthub/dolt#7853

@jycor jycor requested a review from zachmu as a code owner May 13, 2024 21:19
@jycor jycor changed the title make row optional make row optional in VALUES constructor and insert statement May 14, 2024
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@jycor jycor merged commit 00461f6 into main May 14, 2024
4 checks passed
@jycor jycor deleted the james/row branch May 14, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make ROW keyword optional in VALUES statement support INSERT INTO ... (VALUES ROW(...)) statement
2 participants