Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional Dependency anaylsis on simple left join doesn't behave as expected. #1894

Open
nicktobey opened this issue Jul 24, 2023 · 1 comment

Comments

@nicktobey
Copy link
Contributor

Put a breakpoint in lookupJoinSelectivity before the call to sql.NewLookupFDs

Run the following SQL:

drop table if exists uv;
CREATE table uv (u int primary key, v int);
insert into uv values (0,0),
	(1,1),
	(2,2),
	(3,3);

drop table if exists pq;
CREATE table pq (p int primary key, q int);
insert into pq values
  (0,0),
  (1,1),
  (2,2),
  (3,3);


  select * from uv
  left join pq on u = p;

As part of costing joins, we attempt to detect lookups that we know will always return at most one row. This is a perfect candidate of such a lookup: We use u as the key into a lookup on the primary key index pq.p. This always has at most one result. So we expect that fds.HasMax1Row() within lookupJoinSelectivity should return true. But it returns false instead, and we fail to prioritize this execution plan.

@max-hoffman
Copy link
Contributor

I think my default approach for LEFT JOIN was heavy handed, left this TODO which I think applies to your example
https://github.com/dolthub/go-mysql-server/blob/main/sql/func_deps.go#L647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants