Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHSL-2020-145: escape ^ character to prevent code injection attacks #34

Merged
merged 1 commit into from
Aug 29, 2020
Merged

GHSL-2020-145: escape ^ character to prevent code injection attacks #34

merged 1 commit into from
Aug 29, 2020

Conversation

kevinbackhouse
Copy link
Contributor

On Windows, opener does not escape the ^ character which can lead to code injection. For example:

const opener = require("opener");
opener(`https://github.com/${user}`);

If ${user} is the string ^&calc, then on Windows this code will open the (meaningless) url https://github.com/%5E in a browser and launch calc.exe.

We discussed this privately with the maintainer, who says that this is not a vulnerability because opener's entire purpose is to execute arbitrary commands.

Copy link
Owner

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@domenic domenic merged commit 77fd779 into domenic:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants