Comments inside function calls are moved to the end

[fredrikekre]

Not sure if this is a conscious choice, or a bug:

julia> using JuliaFormatter

julia> code = """
       f(x, #= y,=# z)
       """;

julia> print(code)
f(x, #= y,=# z)

julia> print(format_text(code))
f(x, z) #= y,=#

[domluna]

right now comments like this are assumed to be "inline comments" so they're appended. It's just a simpler implementation atm. Printing this out right might not actually be that tricky though.

[domluna]

should the #= comment =# length be factored into the maximum margin or not? I'm leaning towards no since it's not actually code

[fredrikekre]

I would say yes, I don't consider character limits to only apply to code. Are trailing comments not counted towards the limit?

[domluna]

they are not

foo(a, b, c) # comment

# would you want this to be

foo(
    a,
    b,
    c,
) # comment

# because `# comment` is over the margin?

there's also a case to be made there's far less control over how a comment can be broken over multiple lines vs. code

If the comment is not trailing then I think there's a case for considering the length, it could go either way.

[fredrikekre]

I would want it to become

# comment
foo(a, b, c)

[fredrikekre]

But to get back to the original issue, I think it would be fine if it counted for non-trailing comments and the result was

f(
  x,
  #= y,=#
  z
)

without touching/breaking up the comment (i.e. if the comment line alone would be over the limit that would be allowed).

[domluna]

that makes sense it could be treated similar to a multiline string