-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dompdf 1.0.2 does not print images #2431
Comments
I even tried the local filename /var/www/img/logo.jpg |
@cperrot We had similar issues and ended up converting images to base64 and then using them in templetes like so |
Can you post a sample of the HTML + CSS? |
I managed to make it work by removing the leading It seems that dompdf thinks the leading |
The fix is available in this pull request: #2256 |
chroot in Dompdf has always been used as a validation not a path adjustment. Thank you for helping clarify for me that the option is poorly named. I think we should fix that and at the same time add actual chroot-like functionality. It's a breaking change so it'll have to be included in a major release. |
In docker-compose, I know they use "context" as a validation, similar to how "chroot" is used in Dompdf, if that can give you ideas on terminology to use. I think most of the confusion also comes from the expected behavior, where it is expected to act like a web browser rather than a filesystem traversal system. This is especially confusing given we are dealing with HTML files in a PHP context, where one would want to generate a page using a view system (such as Smarty for example) and then create a PDF output of it (such as generating a personalized certificate for download). |
i replaced the file src/Image/Cache.php in new vwrsion by old version from 10/10/2017. |
to try reade #2435 |
Follow This |
this makes the algorithm not work correctly. I removed all the new code. I downloaded the old file instead. I do not have this mechanism. so I don't have this problem now. I don't need this new mechanism in the code. therefore, I have no need to make such changes. moreover, these changes affect security. youtube is full of such videos. but my decision to exclude all new code seems to me safer than always allowing it. thanks. |
maybe ! but one time see my video i'm always create genuine content | Is
useful ! And I'm not using any special code
…On Tue, Jul 6, 2021 at 12:14 PM roman ***@***.***> wrote:
this makes the algorithm not work correctly. I removed all the new code. I
downloaded the old file instead. I do not have this mechanism. so I don't
have this problem now. I don't need this new mechanism in the code.
therefore, I have no need to make such changes. moreover, these changes
affect security. youtube is full of such videos. but my decision to exclude
all new code seems to me safer than always allowing it. thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2431 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATEKZRM4X657DY2OX5722TLTWNIYDANCNFSM42SPELJA>
.
|
I watched the video before I wrote the message. the video changes the operation of the condition. thus, the code will not work correctly according to the idea of the creator. which theoretically can be considered equal to the fact that this check is missing. this is also equal to deleting the verification code. previously, this check was not carried out. I replaced the new file with an old one that did not have a check. theoretically, our actions on the final result are equal. |
we will wait for the creator to release a new version with a fix. |
Ok thanks but i am new on YouTube for solving problems about PHP ! Thanks
for replying
…On Wed, 7 Jul, 2021, 1:40 am roman, ***@***.***> wrote:
we will wait for the creator to release a new version with a fix.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2431 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATEKZRIYI4B4DAMR35GMAZLTWNPJ7ANCNFSM42SPELJA>
.
|
The OP hasn't responded and the issue introduced with the changes to how the chroot option is handled is sufficiently documented. If you have further questions post in the discussion forum or open a new issue for a suspected bug. |
I have tried with local path to load images and with isRemoteEnabled as well.
It does not load under any circumstances the image.
changed as well from gif to jpg
The text was updated successfully, but these errors were encountered: