The header content contains invalid characters

[virtser]

היי, מישהו כתב לנו באינטרקום שהוא מנסה להעלות דירה ולא מצליח
מתקבלת הועה בשלב 3 The header content contains invalid characters
מה זה יכול להיות לדעתך?

As couldn't reproduced myself but found few evidences of this issue in Internet, trying to fix the issue by upgrading related modules.

Some special Hebrew chars in header/cookies must be failing it.

As we saw it in our logs:

{
  "application": "front-gateway",
  "name": "error-handler.js",
  "hostname": "9efa69355168",
  "pid": 36,
  "level": "ERROR",
  "err": {
    "message": "The header content contains invalid characters",
    "name": "TypeError",
    "stack": "TypeError: The header content contains invalid characters\n    at ClientRequest.OutgoingMessage.setHeader (_http_outgoing.js:358:11)\n    at new ClientRequest (_http_client.js:86:14)\n    at Object.exports.request (http.js:31:10)\n    at makeRequest (/home/nodejs/app/node_modules/newrelic/lib/instrumentation/core/http.js:423:31)\n    at instrumentRequest (/home/nodejs/app/node_modules/newrelic/lib/transaction/tracer/instrumentation/outbound.js:28:19)\n    at wrapped (/home/nodejs/app/node_modules/newrelic/lib/transaction/tracer/index.js:183:28)\n    at Tracer.addSegment (/home/nodejs/app/node_modules/newrelic/lib/transaction/tracer/index.js:83:48)\n    at instrumentOutbound (/home/nodejs/app/node_modules/newrelic/lib/transaction/tracer/instrumentation/outbound.js:19:23)\n    at Object.wrappedRequest [as request] (/home/nodejs/app/node_modules/newrelic/lib/instrumentation/core/http.js:417:14)\n    at Request.start (/home/nodejs/app/node_modules/request/request.js:744:32)\n    at Request.write (/home/nodejs/app/node_modules/request/request.js:1421:10)\n    at IncomingMessage.ondata (_stream_readable.js:555:20)\n    at emitOne (events.js:96:13)\n    at IncomingMessage.emit (events.js:188:7)\n    at IncomingMessage.wrapped (/home/nodejs/app/node_modules/newrelic/lib/transaction/tracer/index.js:183:28)\n    at IncomingMessage.wrappedEmit [as emit] (/home/nodejs/app/node_modules/newrelic/lib/transaction/tracer/index.js:220:46)\n    at IncomingMessage.Readable.read (_stream_readable.js:381:10)\n    at flow (_stream_readable.js:761:34)\n    at resume_ (_stream_readable.js:743:3)\n    at wrapped (/home/nodejs/app/node_modules/newrelic/lib/transaction/tracer/index.js:183:28)\n    at _combinedTickCallback (internal/process/next_tick.js:74:11)\n    at process._tickDomainCallback [as _tickCallback] (internal/process/next_tick.js:122:9)"
  },
  "requestId": "b00673de-1859-4ba9-af72-b7296022dad1",
  "msg": "Server Error",
  "time": "2017-04-16T07:43:47.067Z",
  "v": 0
}

[virtser]

I've found related bug in request library that we are using: request/request#2120

[virtser]

Also in koajs: koajs/koa#897

[virtser]

@avnersorek could you think of use cases how to reproduce it based on our usage of header/cookies in code?
How special chars could come into header/cookies?

[avnersorek]

our header contains a lot of stuff so it's hard to say.
As this is happening a couple of times everyday - https://service.eu.sumologic.com/ui/#section/search/pyyG0pEDee1wSisH5t20semPKYT3unefx0JcZnaA

I think we should start by logging the headers when it happens - dorbel-tech/dorbel-shared#70

[virtser]

We are still getting this error: