-
|
We've found that the RoleTable struct contains an Upsert field (https://github.com/dosco/graphjin/blob/master/core/config.go#L166) but the AddRoleTable method is not considering the Upsert type here https://github.com/dosco/graphjin/blob/master/core/config.go#L321. Is it possible that the Upsert type is missing there? Or is there another way to set Upsert permissions on a role that we are not considering? |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 3 replies
-
|
Looks like bug. If this fix satisfies your requirements then feel free to send me a PR else I can make this fix later today. |
Beta Was this translation helpful? Give feedback.
-
|
Here's a PR with the fix, let me know if it looks good for you: #388 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the PR. I think initially I'm still not sure if upsert needed its own config values or if it should use the ones from insert and update. |
Beta Was this translation helpful? Give feedback.
-
|
We found a few more things that were not working properly related to the upsert mutation. Here's another PR with those fixes: #390 |
Beta Was this translation helpful? Give feedback.
Looks like bug. If this fix satisfies your requirements then feel free to send me a PR else I can make this fix later today.