Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next.js example - Make sure the communities guidelines are met #22992

Closed
fmontes opened this issue Sep 14, 2022 · 2 comments
Closed

next.js example - Make sure the communities guidelines are met #22992

fmontes opened this issue Sep 14, 2022 · 2 comments

Comments

@fmontes
Copy link
Member

fmontes commented Sep 14, 2022

Is your feature request related to a problem? Please describe.

First some context. Next.js allows developers to add examples on how to use next.js with anything, including CMSs.

So, we forked their repo and add a /examples/cms-dotcms and do the PR, after some code reviews they still haven't merged so I think is because we're not meeting all the community guidelines.

Describe the solution you'd like

Make sure we are meeting all the community guidelines

Describe alternatives you've considered

N/A

Additional context

N/A

Acceptance criteria

  • Meet all the community guidelines in the code.
@fmontes
Copy link
Member Author

fmontes commented Sep 14, 2022

@hmoreras hmoreras assigned hmoreras and unassigned hmoreras Sep 15, 2022
@rjvelazco rjvelazco self-assigned this Sep 26, 2022
@rjvelazco
Copy link
Contributor

We have already fixed everything on the guidelines. Now, it's up to the Vercel team to review/merge the example.

vercel/next.js#38214

@fmontes fmontes closed this as completed Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants