fix(cli): handle missing dependencies correctly (#4818)

* fix(cli): handle missing dependencies correctly * chore: changeset * test: update check for missing dependency
dotansimha · Sep 29, 2020 · 2900ee2 · 2900ee2
1 parent ef0e7c4
commit 2900ee2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/twenty-dingos-remain.md b/.changeset/twenty-dingos-remain.md
@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/cli': patch
+---
+
+Check the error code instead of the error message to determine if a package wasn't found
diff --git a/packages/graphql-codegen-cli/src/plugins.ts b/packages/graphql-codegen-cli/src/plugins.ts
@@ -22,7 +22,7 @@ export async function getPluginByName(
     try {
       return await pluginLoader(moduleName);
     } catch (err) {
-      if (err.message.indexOf(`Cannot find module '${moduleName}'`) === -1) {
+      if (err.code !== 'MODULE_NOT_FOUND') {
         throw new DetailedError(
           `Unable to load template plugin matching ${name}`,
           `

diff --git a/packages/graphql-codegen-cli/src/presets.ts b/packages/graphql-codegen-cli/src/presets.ts
@@ -18,7 +18,7 @@ export async function getPresetByName(
 
       return loaded as Types.OutputPreset;
     } catch (err) {
-      if (err.message.indexOf(`Cannot find module '${moduleName}'`) === -1) {
+      if (err.code !== 'MODULE_NOT_FOUND') {
         throw new DetailedError(
           `Unable to load preset matching ${name}`,
           `

diff --git a/packages/graphql-codegen-cli/tests/cli-flags.spec.ts b/packages/graphql-codegen-cli/tests/cli-flags.spec.ts
@@ -192,7 +192,7 @@ describe('CLI Flags', () => {
       await createContext(parseArgv(args));
       expect(true).toBeFalsy();
     } catch (e) {
-      expect(e.message).toContain(`Cannot find module 'my-extension'`);
+      expect(e.code).toEqual('MODULE_NOT_FOUND');
     }
   });
 });