Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* use listr2 * try custom renderer * make progress with errors * remove old listr stuff * make test happy * refactor * improve types * changeset * update changeset * Update .changeset/weak-monkeys-wink.md Co-authored-by: Laurin Quast <laurinquast@googlemail.com> Co-authored-by: Laurin Quast <laurinquast@googlemail.com>
- Loading branch information
Showing
6 changed files
with
245 additions
and
742 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
--- | ||
'@graphql-codegen/cli': patch | ||
--- | ||
|
||
### Summary | ||
|
||
- Migrate to [`listr2`](https://listr2.kilic.dev) | ||
- Remove custom renderer for `listr` | ||
- Remove unused dependencies | ||
|
||
### Why | ||
|
||
[`listr`](https://github.com/SamVerschueren/listr) is not actively maintained and we have to maintain our custom renderer for it to display errors. Migrating to `listr2` it just works out of the almost similar to how it was working in past and is a actively maintained. | ||
|
||
### Dev notes | ||
Big change for us is how errors were collected. In `listr` errors were thrown and were caught in the `end` function of our custom `listr` Renderer but with `listr2` we don't really get `Error` in `end` function always so instead we use the [context](https://listr2.kilic.dev/getting-started/the-concept-of-context) to collect errors from all the tasks and then show them after all the tasks are finished. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
2e86ecb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
graphql-code-generator – ./
graphql-code-generator-git-master-theguild.vercel.app
graphql-code-generator.vercel.app
www.graphql-code-generator.com
graphql-code-generator-theguild.vercel.app
www.graphql-codegen.com
graphql-codegen.com
graphql-code-generator.com