fix: make plugins optional for preset (#6305)

dotansimha · Jul 13, 2021 · 470336a · 470336a
1 parent 6fa7e30
commit 470336a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/loud-toys-draw.md b/.changeset/loud-toys-draw.md
@@ -0,0 +1,6 @@
+---
+'@graphql-codegen/cli': patch
+'@graphql-codegen/plugin-helpers': patch
+---
+
+don't require plugins for for config if preset provides plugin. Instead the preset should throw if no plugins were provided.
diff --git a/packages/graphql-codegen-cli/src/codegen.ts b/packages/graphql-codegen-cli/src/codegen.ts
@@ -124,9 +124,9 @@ export async function executeCodegen(input: CodegenContext | Types.Config): Prom
     }
 
     for (const filename of generateKeys) {
-      generates[filename] = normalizeOutputParam(config.generates[filename]);
+      const output = (generates[filename] = normalizeOutputParam(config.generates[filename]));
 
-      if (generates[filename].plugins.length === 0) {
+      if (!output.preset && (!output.plugins || output.plugins.length === 0)) {
         throw new DetailedError(
           'Invalid Codegen Configuration!',
           `

diff --git a/packages/utils/plugins-helpers/src/helpers.ts b/packages/utils/plugins-helpers/src/helpers.ts
@@ -25,7 +25,7 @@ export function isOutputConfigArray(type: any): type is Types.OutputConfig[] {
 }
 
 export function isConfiguredOutput(type: any): type is Types.ConfiguredOutput {
-  return typeof type === 'object' && type.plugins;
+  return (typeof type === 'object' && type.plugins) || type.preset;
 }
 
 export function normalizeOutputParam(config: Types.OutputConfig | Types.ConfiguredOutput): Types.ConfiguredOutput {