refactor: remove unnecessary browser check (#8002)

* refactor: remove unecessary browser check * typo
dotansimha · Jun 30, 2022 · e050230 · e050230 · vercel · Jun 30, 2022
1 parent 8150a9c
commit e050230
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 11 deletions.
diff --git a/.changeset/early-pots-leave.md b/.changeset/early-pots-leave.md
@@ -0,0 +1,5 @@
+---
+'@graphql-codegen/cli': minor
+---
+
+Remove unnecessary browser check
diff --git a/packages/graphql-codegen-cli/src/utils/cli-error.ts b/packages/graphql-codegen-cli/src/utils/cli-error.ts
@@ -1,5 +1,4 @@
 import { DetailedError } from '@graphql-codegen/plugin-helpers';
-import { isBrowser, isNode } from './is-browser';
 
 type CompositeError = Error | DetailedError;
 type ListrError = Error & { errors: CompositeError[] };
@@ -21,9 +20,7 @@ export function cliError(err: any, exitOnError = true) {
   // eslint-disable-next-line no-console
   console.error(msg);
 
-  if (exitOnError && isNode) {
+  if (exitOnError) {
     process.exit(1);
-  } else if (exitOnError && isBrowser) {
-    throw err;
   }
 }
diff --git a/packages/graphql-codegen-cli/src/utils/is-browser.ts b/packages/graphql-codegen-cli/src/utils/is-browser.ts