From e050230c030eb975973564cf9209eae17410931e Mon Sep 17 00:00:00 2001 From: Saihajpreet Singh Date: Thu, 30 Jun 2022 12:28:35 -0500 Subject: [PATCH] refactor: remove unnecessary browser check (#8002) * refactor: remove unecessary browser check * typo --- .changeset/early-pots-leave.md | 5 +++++ packages/graphql-codegen-cli/src/utils/cli-error.ts | 5 +---- packages/graphql-codegen-cli/src/utils/is-browser.ts | 7 ------- 3 files changed, 6 insertions(+), 11 deletions(-) create mode 100644 .changeset/early-pots-leave.md delete mode 100644 packages/graphql-codegen-cli/src/utils/is-browser.ts diff --git a/.changeset/early-pots-leave.md b/.changeset/early-pots-leave.md new file mode 100644 index 00000000000..14a975b2bdb --- /dev/null +++ b/.changeset/early-pots-leave.md @@ -0,0 +1,5 @@ +--- +'@graphql-codegen/cli': minor +--- + +Remove unnecessary browser check diff --git a/packages/graphql-codegen-cli/src/utils/cli-error.ts b/packages/graphql-codegen-cli/src/utils/cli-error.ts index 46acf8a9b99..123edfea089 100644 --- a/packages/graphql-codegen-cli/src/utils/cli-error.ts +++ b/packages/graphql-codegen-cli/src/utils/cli-error.ts @@ -1,5 +1,4 @@ import { DetailedError } from '@graphql-codegen/plugin-helpers'; -import { isBrowser, isNode } from './is-browser'; type CompositeError = Error | DetailedError; type ListrError = Error & { errors: CompositeError[] }; @@ -21,9 +20,7 @@ export function cliError(err: any, exitOnError = true) { // eslint-disable-next-line no-console console.error(msg); - if (exitOnError && isNode) { + if (exitOnError) { process.exit(1); - } else if (exitOnError && isBrowser) { - throw err; } } diff --git a/packages/graphql-codegen-cli/src/utils/is-browser.ts b/packages/graphql-codegen-cli/src/utils/is-browser.ts deleted file mode 100644 index 009510bb356..00000000000 --- a/packages/graphql-codegen-cli/src/utils/is-browser.ts +++ /dev/null @@ -1,7 +0,0 @@ -declare let window: any, process: any; - -const isBrowser = typeof window !== 'undefined' && typeof window.document !== 'undefined'; - -const isNode = typeof process !== 'undefined' && process.versions != null && process.versions.node != null; - -export { isBrowser, isNode };