Can`t find release notes for @graphql-codegen/typescript v4

[kyptov]

Is it a good idea changing Scalar type ID from string to string | number? I think it is better to left ID input as string for backward compability. And those who needs number - can change it.

I beleive using uuid for ID is a best choice and I think most of the devs thinks same way.

[simontaisne]

I'm also seeking the rationale behind this change. Meanwhile, I'm overriding the built-in ID scalar to a string type as described here https://the-guild.dev/graphql/codegen/plugins/typescript/typescript-resolvers#scalars.

const config: CodegenConfig = {
   // ...
   generates: {
     'path/to/file': {
       // plugins...
       config: {
         scalars: {
           ID: {
             input: 'string',
             output: 'string'
           },
         }
       },
     },
   },
};

[dotansimha]

Seems like GitHub cut off some of the release notes under Releases.
You can find it here:
https://github.com/dotansimha/graphql-code-generator/blob/master/packages/plugins/typescript/typescript/CHANGELOG.md#400

[n1ru4l]

If the type if the argument is string | number there is a bug in graphql code generator (coercion input type instead of output type used here_. The arguments within the resolver function should be coerced to the output type.

[simontaisne]

The arguments within the resolver function should be coerced to the output type.

So, following this changelog that would be correct then?

Note that for typescript-resolvers, the type of ID needs to be inverted 🤷

export type Scalars = {
  ID: {
    input: string;
    output: string | number;
  }
}

[eddeee888]

Hello @simontaisne 👋

To generate types for the server, we'd have to change the default scalar types in codegen config:

const config: CodegenConfig = {
   // ...
   generates: {
     'path/to/file': {
       // plugins...
       config: {
         scalars: {
           ID: { 
             input: 'string', 
             output: 'string | number' 
           },
         }
       },
     },
   },
};

This should correctly type coerced input in args. This also mean resolver functions can return string | number values that end up in the parent of subsequent resolvers.

---

Alternatively, you can make ID input/output string to preserve the previous behaviour (similar to what you suggested):

const config: CodegenConfig = {
   // ...
   generates: {
     'path/to/file': {
       // plugins...
       config: {
         scalars: {
           ID: 'string'
         }
       },
     },
   },
};

[simontaisne]

Thanks @eddeee888, this confirms the current behavior then. Appreciate it 👍

[eddeee888]

Hi @simontaisne,

FYI, the default type for ID input/output has been reverted back to string in the latest patch released here: #9501 🙂