Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HOC data props with custom type names #2166

Merged
merged 1 commit into from
Jul 14, 2019

Conversation

jlkiri
Copy link
Contributor

@jlkiri jlkiri commented Jul 13, 2019

This PR addresses the following issue: #2160

When custom operation result type name is specified by operationResultSuffix config option, React Apollo HOC props are generated with a wrong operation type name. This PR fixes the way HOC props are generated.

Expected example (with operationResultSuffix set to Response):

export type BooksProps<TChildProps = {}> = Partial<
  ReactApollo.DataProps<BooksQueryResponse, BooksQueryVariables>
> &
  TChildProps;

@dotansimha
Copy link
Owner

Perfect, thank you @jlkiri !

@dotansimha dotansimha merged commit 0a54de3 into dotansimha:master Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants