Minor type changes for visitor-plugin-common

[midzdotdev]

Currently, when calling visit with a visitor extending the BaseTypesVisitor in the @graphql-codegen/visitor-plugin-common package, the compiler throws a wobbly because the types do not match. Example:

import { visit } from 'graphql'
const visitorResult = visit(astNode, { leave: visitor })

If it matters, the full error at { leave: visitor } is this:

Argument of type '{ leave: Visitor<PluginConfig, ParsedConfig>; }' is not assignable to parameter of type 'Visitor<ASTKindToNode, ASTNode>'.
  Type '{ leave: Visitor<PluginConfig, ParsedConfig>; }' is not assignable to type 'EnterLeave<VisitFn<ASTNode, ASTNode> | { Name?: VisitFn<ASTNode, NameNode> | undefined; Document?: VisitFn<ASTNode, DocumentNode> | undefined; OperationDefinition?: VisitFn<ASTNode, OperationDefinitionNode> | undefined; ... 39 more ...; InputObjectTypeExtension?: VisitFn<...> | undefined; }>'.
    Types of property 'leave' are incompatible.
      Type 'Visitor<PluginConfig, ParsedConfig>' is not assignable to type 'VisitFn<ASTNode, ASTNode> | { Name?: VisitFn<ASTNode, NameNode> | undefined; Document?: VisitFn<ASTNode, DocumentNode> | undefined; OperationDefinition?: VisitFn<ASTNode, OperationDefinitionNode> | undefined; ... 39 more ...; InputObjectTypeExtension?: VisitFn<...> | undefined; } | undefined'.
        Type 'Visitor<PluginConfig, ParsedConfig>' is not assignable to type '{ Name?: VisitFn<ASTNode, NameNode> | undefined; Document?: VisitFn<ASTNode, DocumentNode> | undefined; OperationDefinition?: VisitFn<ASTNode, OperationDefinitionNode> | undefined; ... 39 more ...; InputObjectTypeExtension?: VisitFn<...> | undefined; }'.
          Types of property 'UnionTypeDefinition' are incompatible.
            Type '(node: UnionTypeDefinitionNode, key: string | number, parent: any) => string' is not assignable to type 'VisitFn<ASTNode, UnionTypeDefinitionNode>'.
              Types of parameters 'key' and 'key' are incompatible.
                Type 'string | number | undefined' is not assignable to type 'string | number'.
                  Type 'undefined' is not assignable to type 'string | number'.

And now it works, voila! Apologies for the slightly hacky nature of the fix.

[dotansimha]

Thank you @james2mid !