Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation in all plugins #2508

Merged
merged 7 commits into from
Sep 16, 2019
Merged

Federation in all plugins #2508

merged 7 commits into from
Sep 16, 2019

Conversation

kamilkisiela
Copy link
Collaborator

@kamilkisiela kamilkisiela commented Sep 6, 2019

@dotansimha
Copy link
Owner

dotansimha commented Sep 8, 2019

@kamilkisiela maybe we can add something like?

schema:
   - my-schema.graphql
   - federation

And it will add all required schema types?

Because I'm still not 100% sure that putting Federation code inside the common libs is the best solution.

@kamilkisiela
Copy link
Collaborator Author

kamilkisiela commented Sep 9, 2019

@dotansimha by - federation you mean a string that equals federation or a federation.graphql?

I think it should be inside the config because otherwise how do you know plugins should generate something federation-specific and what in case where someone wants to use federation within only one plugin and not the others (same generated file)?

I'm not sure what's bad in putting federation in common lib. There's a shared logic between multiple plugins so it is common.

@dotansimha
Copy link
Owner

@kamilkisiela ci :)

@kamilkisiela kamilkisiela force-pushed the federation/in-introspection branch from d33e564 to 131f573 Compare September 16, 2019 09:48
@kamilkisiela kamilkisiela force-pushed the federation/in-introspection branch from 5de2f31 to 8acb934 Compare September 16, 2019 11:37
@kamilkisiela kamilkisiela marked this pull request as ready for review September 16, 2019 11:37
@kamilkisiela kamilkisiela merged commit 2a64793 into master Sep 16, 2019
@kamilkisiela kamilkisiela deleted the federation/in-introspection branch September 16, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants