Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix plugin Typescript mongoDB: generate optional type for @map #4417

Merged
merged 2 commits into from Jul 23, 2020
Merged

Fix plugin Typescript mongoDB: generate optional type for @map #4417

merged 2 commits into from Jul 23, 2020

Conversation

xiaoliu-heng
Copy link
Contributor

@xiaoliu-heng xiaoliu-heng commented Jul 23, 2020 •
edited 

name: String @column @map(path: "fullName")

output before:

fullName: Maybe<string>

fixed output

fullName?: Maybe<string>

@xiaoliu-heng xiaoliu-heng changed the title Fix plugin Typescript mongoDB generate optional type for @map use the GraphQL AST Fix plugin Typescript mongoDB generate optional type for @map Jul 23, 2020
@xiaoliu-heng xiaoliu-heng changed the title Fix plugin Typescript mongoDB generate optional type for @map Fix plugin Typescript mongoDB: generate optional type for @map Jul 23, 2020
@dotansimha
Copy link
Owner

That's perfect! Thank you so much @xiaoliu-heng !

@dotansimha dotansimha merged commit c2f94b0 into dotansimha:master Jul 23, 2020
@theguild-bot
Copy link
Collaborator

The latest changes of this PR are available as alpha in npm: 1.17.4-alpha-c2f94b01.0

Quickly update your package.json by running:

npx match-version @graphql-codegen 1.17.4-alpha-c2f94b01.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiaoliu-heng @dotansimha @theguild-bot