Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials: true is not being passed to PlayGround. #255

Closed
0xDaksh opened this issue Apr 11, 2018 · 5 comments
Closed

Credentials: true is not being passed to PlayGround. #255

0xDaksh opened this issue Apr 11, 2018 · 5 comments

Comments

@0xDaksh
Copy link
Contributor

0xDaksh commented Apr 11, 2018

To Authenticate with cookies, it should send all the cookies to the server but graphql-playground by default in graphql-yoga doesn't have credentials: true in it's fetch options and that's why the server doesn't receive any cookies.

@xuo
Copy link

xuo commented Jul 7, 2018

As far as i understand, you can set "request.credentials" to either "include" or "same-origin" in the Playground settings.
See this PR for reference.

@0xDaksh
Copy link
Contributor Author

0xDaksh commented Jul 8, 2018

yea, I solved this quite a while ago and totally forgot about this issue. But i think by default it should be set to include or same-origin, because most people while learning graphql don't know about this and it makes it harder for them.

@ramirotw
Copy link

Changing the request.credentials config option is not working using the current version of graphql-yoga.

Maybe it's related with this issue: graphql/graphql-playground#791

@mwilc0x
Copy link

mwilc0x commented Jul 19, 2018

It is working for me with 1.14.12

@0xDaksh
Copy link
Contributor Author

0xDaksh commented Aug 10, 2018

As there is no update on this.

I would suggest anyone coming here, to just set:

request.credentials to include.

@0xDaksh 0xDaksh closed this as completed Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants